nuxt-community / starter-template

DEPRECATED: use create-nuxt-app instead
https://github.com/nuxt-community/create-nuxt-app
MIT License
607 stars 330 forks source link

Lint does not run on save automatically. #64

Closed unr closed 6 years ago

unr commented 6 years ago

Version

nuxt-edge

Reproduction link

https://github.com/unr/eslint-error-example

Steps to reproduce

In my repo, I'm working with nuxt-edge as well, though this seems to cause no difference. Error occurs on 1.4.0 nuxt eslint-fail.png

What is expected ?

Eslint should run via eslint-loader on file save, reporting vue & js linting errors.

What is actually happening?

Lint can be manually run, doesn't run automatically.

Additional comments?

This used to work previously, and I've tried multiple types of setting up eslint-loader. None seem to work.

This bug report is available on Nuxt.js community (#c42)
unr commented 6 years ago

Turns out... I may have misunderstood the docs.

ctx available here: https://nuxtjs.org/guide/development-tools#eslint-and-prettier

Does not seem to be context as presented by api here: https://nuxtjs.org/api/context


IE, ctx.isClient is not deprecated like context.isClient... and should be used in my build.

It started working again, once I stopped using if (process.client) in my build.

unr commented 6 years ago

This isn't a real issue, couldn't see how to close it in CMTY...