search

nuxt-community / universal-storage-module

Universal Storage Utilities for Nuxt 2
MIT License
276 stars 15 forks source link

setCookie [SSR]: Do not override existing cookies with new one. #183

Open misterpekert opened 3 years ago

misterpekert commented 3 years ago

As per setHeader documentation:

If this header already exists in the to-be-sent headers, its value will be replaced

So, whenever $storage.setCookie() is called on SSR side, it replaces all cookies which were set before and it's impossible to set 2 different cookies using $storage.setCookie() on SSR, as only the last one will get into "Set-Cookies" header.

This PR aims to fix this issue.

misterpekert commented 3 years ago

@pi0 any chance this will get reviewed and released? 🤔

misterpekert commented 2 years ago

Any updates?

misterpekert commented 2 years ago

@farzadso is this project still being maintained? This PR is already 3m without any feedback.

misterpekert commented 1 year ago

1 year passed, who cares, right? :)