Closed jessielaf closed 5 years ago
@jessielaf It looks like you just have not node_modules
up to date, I mean your issue is cause Vuetify main.sass
file seems to somehow contain semicolons but it shouldn't.
Can you try purge your node_modules
& reinstall dependencies ?
I did that but still getting the same problem. The problem is in my variables.scss. I already used scss in my application and vuetify uses sass. This makes that the sass loader is loaded but the variables file is scss. It works in dev mode though
@jessielaf Could you create a repository with the reproduction please ? :) So I can debug easier
@kevinmarrec I can't seem to reproduce it. Is it okay if I add you to my private repo?
@jessielaf If you don't have sensitive data, yes sure you'll be able to remove me afterwards
Done! Thanks for the help
@jessielaf I'll check when I've some time :)
Thanks! By the way I changed a bit of code so it looked more like the normal implementation. The error that is expected is:
And everything can be found in the update-vuetify
branch
@jessielaf Okay I took a look and here is my feedback :
You're using dayspan-vuetify
which rely on Vuetify 1.3.9, so be aware of that
SASS/SCSS issue seems to come from styleResources
, I don't know how to deal with it so I prepared a branch with a fix, I didn't create a PR yet as you probably don't want traces in commits, so you can just copy paste changes, the name of the branch is fix-sass-issue-on-update-vuetify
, feel free to delete it afterwards.
I think styleResources
module is conflicting around node-sass
vs dart-sass
, I don't have any workaround except the commit I proposed on the fixed branch, which means not using @nuxtjs/styleResources
(and yes it means having to copy imports whenever you have to use variables in components)
Hmm that is weird I added that module when I tried to reproduce it and it did not give me a problem. Maybe I didn't use it right. Anyway thank you! I will create a new issue on @nuxtjs/styleResources
. I know I use dayspan-vuetify thats why I want to go to version 2.0!
/cc @jessielaf https://github.com/nuxt-community/style-resources-module/issues/67 has been fixed by https://github.com/nuxt-community/style-resources-module/pull/69 released in 1.0.0 of the module, you can upgrade it & enjoy ! :)
Hi guys,
I am trying to upgrade to vuetify 2 but I keep running into some problems. It is that of the switch to dart-sass. I am was node-sass before but as shown in the vuetify upgrade guide they use dart-sass.
Everything worked when using it in demo. Probably because the vuetify module is in devModules. So I added this to my
nuxt.config.js
But this also didn't work. The error that I keep seeing:
I tried it with node-sass and sass package with it also being in my loaders. The only option I am seeing right now is to change all my scss to sass which is far from ideal.
My nuxt config looks like this:
Version
Thanks in advance!