search

nuxt-hub / core

Build full-stack applications with Nuxt on CloudFlare, with zero configuration.
https://hub.nuxt.com
Apache License 2.0
802 stars 35 forks source link

feat: add pkg.pr.new #157

Closed Aslemammad closed 2 weeks ago

Aslemammad commented 2 weeks ago

A debugging session for nuxt hub!

farnabaz commented 2 weeks ago

@Aslemammad autofix ci is failing

Aslemammad commented 2 weeks ago

yea i'm experimenting and debugging pkg.pr.new at the same time 😅

Aslemammad commented 2 weeks ago

let's try this time!

Atinux commented 2 weeks ago

Why changing the prepack command @Aslemammad ?

Aslemammad commented 2 weeks ago

The reason is that when we json parse the output of npm pack, it has the address of the tarball. But when using the prepack hook we're adding output to the default json ouput of npm pack --json and that breaks the parsing.

I'm trying to verify my assumptions! let me know what do you think.

Aslemammad commented 2 weeks ago

just pushed a new update, can we try now? sorry for disturbing!

pkg-pr-new[bot] commented 2 weeks ago

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@nuxthub/core (2e393cc)

npm i https://pkg.pr.new/nuxt-hub/core/@nuxthub/core@157
Aslemammad commented 2 weeks ago

I guess this is working now! I'll try to find a way to support packing hooks like prepack in pkg.pr.new, but it might be complicated. let's see.

meanwhile, we can have this merged if you want! Thank you all for the huge opportunity ❤️

Aslemammad commented 2 weeks ago

I destroyed this branch, sorry, pushed to #164!