nuxt-hub / core

Build full-stack applications with Nuxt on CloudFlare, with zero configuration.
https://hub.nuxt.com
Apache License 2.0
993 stars 57 forks source link

[admin] Adding custom domains should add the CNAME record if domain on same CF account #315

Open egoist opened 1 month ago

egoist commented 1 month ago

Describe the bug

Adding custom domains through NuxtHub dashboard successfully added it for the Worker/Page, but it doesn't create the CNAME record for it on Cloudflare. If I add the domain in Cloudflare Workers settings directly, it will create the CNAME record for me

Steps to reproduce Steps to reproduce the behavior:

  1. create a Hello NuxtHub project
  2. add a custom domain

Expected behavior A clear and concise description of what you expected to happen.

Should add the CNAME for me

atinux commented 1 month ago

Actually we don't have the permissions to access your domains, so we cannot know that you already added the domain to your Cloudflare account and that we can add the CNAME for it.

Will keep it for when we will support domains on NuxtHub, thanks for the feedback ❤️