SSR Instantsearch implementation

nuxt-modules / algolia

🔎 Algolia module for Nuxt

https://algolia.nuxtjs.org/

MIT License

185 stars 32 forks source link

SSR Instantsearch implementation #187

Closed Rigo-m closed 5 months ago

Rigo-m commented 8 months ago

Take a look at this. It's a different (and imho better) way to implement SSR Instantsearch on algolia. It does not require you to write a carbon copy of the render function of the component, and it's more understandable how it works.

@Baroshem let me know what you think

Baroshem commented 8 months ago

Hey @Rigo-m

Thanks for this change! I will take a look at it in the upcoming days

LoMonacoSalvatore commented 8 months ago

hi @Baroshem! Any news?

Baroshem commented 8 months ago

Hey folks,

Sorry for no contact. I have been recently busy with other modules.

I will set it as a priority to handle this once I will be back from vacation 1st December.

I will review this and possibly merge as it is a good example :)

Rigo-m commented 8 months ago

Just a quick follow-up with some ideas:

We could generalize the ssr plugin and the SSR Provider component so that it can be implemented more easily
I'm up for an open source instantsearch for vue overhaul. Hit me up on twitter if you want to discuss it, instantsearch implementation in vue/nuxt is not isomorphic, nor performant neither compliant with the vue 3 ecosystem best practices.

Baroshem commented 7 months ago

Hey @Rigo-m

Sorry for long time waiting but I was away for almost two last weeks.

This sounds interesting. Do you think this SSR plugin/provider could be a part of the module and be provided in an easy way for the user to use in their Algolia SSR apps with InstantSearch?
I am not sure about it. I understant the frustration but this Instantsearch is created by Algolia so I would prefer to keep it in the module if possible because it is official library that majority of users ask for (even if it is not perfect).

I am up for showing your GitHub repo as the example in the documentation if you are ok with that but we can also work on implementing a new version of the module with a feature that could make it simplier for users to work with it :)

Rigo-m commented 6 months ago

I think it would be cool to provide it via the module, so that users are encouraged to use the solution and find issues (so that its eventual fix can benefit everyone)

Up to you if you want to provide the components and/or point to this issue in the docs :) I think the previous solution was bad in many ways that's why i opened this.

As per the point number 2, instantsearch for vue really sucks, if by any means my sorry ass starts to move and I start to do some open source work I really want to rewrite algolia's library for vue from the ground up :D

Baroshem commented 6 months ago

So my recommendation will be to add the link right now and if you like and have time, I would really appreciate if you could create a Proof of Concept PR with your solution.

I can add the link to the docs in the upcoming days if you agree :)

Then we could decide how to make it work the best way for the users.

Thanks for all the ideas and dedication for making the module better! 💚

Baroshem commented 6 months ago

Added docs mention here

Rigo-m commented 5 months ago

@Baroshem closing this. The proposed SSR implementation had many problems that we encountered in real life applications and a bad DX, started working on something better :)

https://github.com/atoms-studio/nuxt-swiftsearch for everyone stumbling across this issue