nuxt-modules / algolia

🔎 Algolia module for Nuxt
https://algolia.nuxtjs.org/
MIT License
191 stars 35 forks source link

fix(module): rc9 compatibility issues #92

Closed Intevel closed 2 years ago

Intevel commented 2 years ago

Will fix #90 and #91 @Baroshem

Types of changes

netlify[bot] commented 2 years ago

Deploy Preview for nuxt-algolia-module canceled.

Name Link
Latest commit 97c4a10c73fa5964ceaa210d46044b978cd8f166
Latest deploy log https://app.netlify.com/sites/nuxt-algolia-module/deploys/6319e16baf8aaa0008eef813
Lexpeartha commented 2 years ago

Not a module author, but it might be helpful to add a message in docs that says rc 9 of nuxt is required version in order to function?

lukaszflorczak commented 2 years ago

It looks that addAutoImportDir() is also (soft) depreciated and changed to addImportsDir()

Source: https://github.com/nuxt/framework/pull/7158

Intevel commented 2 years ago

The autoImports hook was deprecated, or am I wrong?

lukaszflorczak commented 2 years ago

They renamed utils:

Updated kit utils: Soft deprecated (type only) addAutoImport to addImports and addAutoImportDir to addImportsDir for consistency

Intevel commented 2 years ago

Ah okay thank you, I will update this.

Baroshem commented 2 years ago

Hey folks,

thanks for this PR. I am back from holidays and will merge this PR and release a new version so that you could use it without errors tomorrow.

Thanks for the patience.

Baroshem commented 2 years ago

Not a module author, but it might be helpful to add a message in docs that says rc 9 of nuxt is required version in order to function?

@Lexpeartha I think that the support for the most recent RC version is expected when using the module. Right now, the module does not work with the most current version of the Nuxt so all new Nuxt project have the Algolia module disabled. I dont think this info needs to be added to the docs. As a software user, I expect it to work with the most modern and stable update :)

Baroshem commented 2 years ago

Guys, the new version has been released. You can verify now if it works correctly. I have tested it in several nuxt projects and it is working correctly :)