search

nuxt-modules / cloudinary

Cloudinary Module for Nuxt
https://cloudinary.nuxtjs.org
MIT License
249 stars 34 forks source link

hideContextMenu property #145

Closed wramzo closed 12 months ago

wramzo commented 1 year ago

Hi, I request you to add hideContextMenu property for video player. I wish you good work

Baroshem commented 1 year ago

Hey @ramzzo

Thanks for this feature request.

Could you share more details about what you would like to achieve with it? Like what is the reasoning behind having it? Maybe there is an example in the docs or other libraries that could point me to what you are trying to achieve?

colbyfayock commented 1 year ago

@Baroshem does the video player currently support an options prop? If so you should be able to pass it in there.

It's a widget configuration option. Can find it here

https://cloudinary.com/documentation/video_player_api_reference

A question I've been asking myself is which ones make sense to expose at a top level or leave in options

wramzo commented 1 year ago

Hey @ramzzo

Thanks for this feature request.

Could you share more details about what you would like to achieve with it? Like what is the reasoning behind having it? Maybe there is an example in the docs or other libraries that could point me to what you are trying to achieve?

I see the context menu in the video player as unnecessary and it breaks the design. On the other hand, the cloudinary version is written in the context menu. This removes the corporate atmosphere.

Baroshem commented 1 year ago

@colbyfayock

VideoPlayer accepts some of the props from the video player so I would recommend to add a new props as I did in the linked PR.

@ramzzo could you check the PR to see if this makes sense for you? I checked it and it disables the context menu but maybe there is something more that I missed.

Baroshem commented 12 months ago

@ramzzo

Any info from you?

colbyfayock commented 11 months ago

hey @Baroshem i noticed this issue when spinning up my dev locally, before opening a ticket, i just wnted to check and see if this is something on my end? wondering if it was accidentally not marked as optional: https://github.com/nuxt-modules/cloudinary/pull/148/files#diff-10a44c863aaf04f992a978372f4bdab1f4609723ec71ad640fb02f3d7a227cf4R22

image
Baroshem commented 11 months ago

Hey @colbyfayock. Yes, you are correct. I must have forgotten about marking this prop as optional. I will fix it in a sec