nuxt-modules / cloudinary

Cloudinary Module for Nuxt
https://cloudinary.nuxtjs.org
MIT License
249 stars 34 forks source link

Fix typescript error in CldOgImage.vue #146

Closed jbmolle closed 1 year ago

jbmolle commented 1 year ago

Fix #147

Types of changes

Description

computedTwitterTitle in CldOgImage.vue uses currentRoute which is a ref value. To access the value, we should use currentRoute.value Currently currentRoute.meta throws a Typescript error and it's not possible to compile the app with Typescript checks.

Checklist:

netlify[bot] commented 1 year ago

Deploy Preview for nuxt-cloudinary-module canceled.

Name Link
Latest commit e0635a12dd4ed15a10848da9be4621135d5b8339
Latest deploy log https://app.netlify.com/sites/nuxt-cloudinary-module/deploys/64e8caa2d6c7960008e4786c
Baroshem commented 1 year ago

Hi!

Thank you so much for this PR! I will review it, merge it, and release a new patch version with it quite soon :)