search

nuxt-modules / cloudinary

Cloudinary Module for Nuxt
https://cloudinary.nuxtjs.org
MIT License
249 stars 34 forks source link

[Feature] Throw an error or warning in components if a cloud name is not set #159

Closed Baroshem closed 11 months ago

Baroshem commented 1 year ago

A Cloud name is required, whether set via VITE_PUBLIC_CLOUDINARY_CLOUD_NAME or via the config prop. The component should throw an error or warning in the event that it's not configured.

suvekshyabhandari356 commented 12 months ago

@Baroshem I would like to work on this issue

Baroshem commented 12 months ago

Awesome, assigning to you :)

suvekshyabhandari356 commented 12 months ago

@Baroshem I need some help here. Just realized that the module.ts file already has this https://github.com/nuxt-modules/cloudinary/blob/main/src/module.ts#L37-L40

Do I need to add something else? 🤔 Your help is really appreciated here 🙏

Baroshem commented 12 months ago

Hey,

You are correct. It is handled in the module configuration. Good catch 😉

And if it is not passed as component, user still needs to add it to the module configuration.

So this can be closed as completed (unintentionally 😉)

Thanks for finding it! If you would like to contribute more to the module, make sure to check out other issues as well. I will gladly help you with any other features there :)