search

nuxt-modules / cloudinary

Cloudinary Module for Nuxt
https://cloudinary.nuxtjs.org
MIT License
245 stars 31 forks source link

CldVideoPlayer config prop #196

Closed colbyfayock closed 3 months ago

colbyfayock commented 3 months ago

Is your feature request related to a problem? Please describe.

Allow CldVideoPlayer to take a config prop, much like CldImage, which can control advanced Cloudinary settings

This would then ideally inherit module-level configuration that's being set up via: https://github.com/nuxt-modules/cloudinary/issues/195

Describe the solution you'd like

The Next.js implementation currently passes through any valid option that's defined in the source types from cloudinary-util/types

https://github.com/cloudinary-community/next-cloudinary/blob/main/next-cloudinary/src/components/CldVideoPlayer/CldVideoPlayer.tsx#L44

https://github.com/colbyfayock/cloudinary-util/blob/main/packages/types/src/types/cloudinary-video-player.d.ts

It doesnt look liek the work was done yet to use the types from the new package: https://github.com/nuxt-modules/cloudinary/issues/186

By adding the same thing, this would allow any of the configuration options to "just work"

Baroshem commented 3 months ago

Quick question about global config. Are you sure that we want to pass the config from global configuration to the CldVideoPlayer as well? The global config uses the CloudinaryConfigurationOptions that is the same for the constructCloudinaryUrl metho and I am not sure if it is the same as the configuration for the video player. If it is the same, then we are safe to go.

colbyfayock commented 3 months ago

good question about the config, but we need to normalize on something and i think it makes sense to normalize on the config options as defined in ConfigOptions of URL Loader already, which is the same shape that the underlaying URL Gen library uses (official Cloudinary SDK)

<CldImage config should be that same shape, so i'm thinking <CldVideoPlayer config should as well, but then we would need to apply the properties differently than what we do with the image due to the nature of the configuration options

https://github.com/colbyfayock/cloudinary-util/blob/main/packages/url-loader/src/types/config.ts https://github.com/cloudinary/js-url-gen/blob/master/src/config/interfaces/Config/ICloudinaryAssetConfigurations.ts