nuxt-modules / cloudinary

Cloudinary Module for Nuxt
https://cloudinary.nuxtjs.org
MIT License
249 stars 34 forks source link

chore/2.7.0 #200

Closed Baroshem closed 6 months ago

Baroshem commented 6 months ago

Types of changes

Description

Checklist:

netlify[bot] commented 6 months ago

Deploy Preview for nuxt-cloudinary-module ready!

Name Link
Latest commit f692759e39d2baa0532cee3167b1aadc49024322
Latest deploy log https://app.netlify.com/sites/nuxt-cloudinary-module/deploys/66018dda9d85510008820982
Deploy Preview https://deploy-preview-200--nuxt-cloudinary-module.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

colbyfayock commented 6 months ago

@Baroshem this seems to work great! i added a few comments

im also having trouble getting the cname to work on the video player for some reason, but after debugging, i dont believe it has anything to do with your code taht i can find yet, so im unsure why it's not working, but it worked perfectly fine with CldImage with a module-level config

still looking into it

colbyfayock commented 6 months ago

i think i found the issue - those configuration properties might have been a relatively recent addition? or at a minimum, a bug was fixed, where after upgrading to the latest VideoPlayer version, it seems that everything works as expected

so updating 1.9.4 to 1.10.6 inside CldVideoPlayer (and the docs that reference it)

colbyfayock commented 6 months ago

heres what i tested with, though it wont work, you'll be able to see in the web console the URLs with spacejelly.dev in the front

export default defineNuxtConfig({
  modules: ['../src/module'],
  cloudinary: {
    cloudName: 'nuxt-cloudinary',
    url: {
      cname: 'spacejelly.dev',
      secureDistribution: 'spacejelly.dev',
      secure: true,
      privateCdn: true
    }
  }
})