search

nuxt-modules / color-mode

Dark and Light mode with auto detection made easy with Nuxt 🌗
https://color-mode.nuxtjs.org
MIT License
1.07k stars 98 forks source link

Feat: cookie storage #256

Closed juls0730 closed 3 months ago

juls0730 commented 4 months ago

Build off of #221 and make SSR better with cookie storage. The original PR seems a bit dead, and I want to get this past the finish line. I'm unsure if manniL or Hossein-Mirazimi forgot about the PR or something, but I'm trying to just get it merged lol

juls0730 commented 4 months ago

still working on merge conflicts and other small problems, please hold

juls0730 commented 4 months ago

that should have the SSR working, and it will look similar to the demo page (whether its supposed to looks broken I'm unsure, but I made it look like the demo page). Once again, I must thank Hossein-Mirazimi and manniL for the original code for all of their great work

wkl007 commented 2 months ago

@juls0730 How is the progress of this pr now, thank you！

juls0730 commented 2 months ago

Hey @wkl007 i believe it was working when I closed it, but I can check again and confirm

juls0730 commented 2 months ago

update: there is absolutely no way it was working when I closed the PR because I'm pretty confident it was not adding the class server-side, it is now doing that on the latest commit

wkl007 commented 2 months ago

@juls0730 Thank you very much for your reply.