nuxt-modules / color-mode

Dark and Light mode with auto detection made easy with Nuxt 🌗
https://color-mode.nuxtjs.org
MIT License
1.07k stars 98 forks source link

fix: trim minified script #268

Closed Gerbuuun closed 2 months ago

Gerbuuun commented 2 months ago

Possibly resolves #266 #267 #228

see my comments in #266

danielroe commented 2 months ago

This seems likely a bug in Nuxt security module but I don’t see a harm in this hotfix.

Gerbuuun commented 2 months ago

Would be better if this could be achieved in the minification build step itself.

I'll raise the issue with nuxt-security

Gerbuuun commented 2 months ago

They already had a fix ready (https://github.com/Baroshem/nuxt-security/pull/478). You can dismiss this PR if you think it is not necessary

danielroe commented 2 months ago

This PR is good (though the underlying bug in the regexp in nuxt-security does need to be fixed as well.)

Gerbuuun commented 2 months ago

A new version of nuxt-security has been released with the previously linked PR. It works now!