nuxt-modules / eslint

ESLint module for Nuxt.js
MIT License
159 stars 15 forks source link

fix: bridge compatibility #80

Closed ricardogobbosouza closed 1 year ago

codecov[bot] commented 1 year ago

Codecov Report

Merging #80 (c19b76b) into main (6ef7100) will increase coverage by 18.46%. The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             main       #80       +/-   ##
============================================
+ Coverage   81.53%   100.00%   +18.46%     
============================================
  Files           2         2               
  Lines          65        68        +3     
  Branches        7         7               
============================================
+ Hits           53        68       +15     
+ Misses         12         0       -12     
Impacted Files Coverage Δ
src/module.ts 100.00% <100.00%> (+20.00%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

MartinX3 commented 1 year ago

@ricardogobbosouza

 ERROR  [unhandledRejection] Cannot read properties of undefined (reading 'tap')                                                                                                  11:27:49

  at node_modules/.pnpm/eslint-webpack-plugin@4.0.0_p72rhxqnkxdgq5hcokxg4t4deu/node_modules/eslint-webpack-plugin/dist/index.js:120:42
  at SyncHook.eval [as call] (eval at create (node_modules/.pnpm/tapable@1.1.3/node_modules/tapable/lib/HookCodeFactory.js:19:10), <anonymous>:87:1)
  at SyncHook.lazyCompileHook (node_modules/.pnpm/tapable@1.1.3/node_modules/tapable/lib/Hook.js:154:20)
  at Compiler.newCompilation (node_modules/.pnpm/webpack@4.46.0/node_modules/webpack/lib/Compiler.js:631:26)
  at node_modules/.pnpm/webpack@4.46.0/node_modules/webpack/lib/Compiler.js:667:29
  at AsyncSeriesHook.eval [as callAsync] (eval at create (node_modules/.pnpm/tapable@1.1.3/node_modules/tapable/lib/HookCodeFactory.js:33:10), <anonymous>:6:1)
  at AsyncSeriesHook.lazyCompileHook (node_modules/.pnpm/tapable@1.1.3/node_modules/tapable/lib/Hook.js:154:20)
  at Compiler.compile (node_modules/.pnpm/webpack@4.46.0/node_modules/webpack/lib/Compiler.js:662:28)
  at node_modules/.pnpm/webpack@4.46.0/node_modules/webpack/lib/Watching.js:77:18
  at _next1 (eval at create (node_modules/.pnpm/tapable@1.1.3/node_modules/tapable/lib/HookCodeFactory.js:33:10), <anonymous>:25:1)
argoyle commented 1 year ago

Any update on the problem @MartinX3 reported above?

MartinX3 commented 1 year ago

@argoyle I deactivated this modul and wait for a response by @ricardogobbosouza

argoyle commented 1 year ago

Yes, me too. But it removes the eslint-findings during "regular" dev and I have to run linting manually for now. 😄

MartinX3 commented 1 year ago

I use commitlint as git hook, run the lints in "preserve" and "prebuild" and also activated linting on save in IntelliJ as action on save :)

xel1045 commented 1 year ago

Nuxt Bridge use Webpack 4 under the hood, so eslint-webpack-plugin@^2.0.0 should be used, but ^4.0.1 is specified by @nuxtjs/eslint-module.

As a workaround, you could add a resolution to your package.json to force v2 to be installed:

    "resolutions": {
        "eslint-webpack-plugin": "^2.0.0"
    },