search

nuxt-modules / google-fonts

Google Fonts module for NuxtJS
https://google-fonts.nuxtjs.org
MIT License
517 stars 41 forks source link

fix: cssnano on production #171

Closed ricardogobbosouza closed 6 months ago

ricardogobbosouza commented 10 months ago

Resolve #158 A temporary solution.

Maybe this configuration of cssnano should come by default in nuxt, only in production mode

{
  cssnano: {
    preset: ['default', { discardComments: { removeAll: true } }]
  }
}

wdyt @danielroe

netlify[bot] commented 10 months ago

Deploy Preview for pedantic-sinoussi-65c819 canceled.

Name Link
Latest commit 57d98135918ea1617763ef42a4248aa45d589bc3
Latest deploy log https://app.netlify.com/sites/pedantic-sinoussi-65c819/deploys/65731c9c1d97e4000884b6d6
codecov[bot] commented 10 months ago

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (9722275) 89.51% compared to head (57d9813) 85.77%.

Files Patch % Lines
src/module.ts 29.41% 12 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #171 +/- ## ========================================== - Coverage 89.51% 85.77% -3.75% ========================================== Files 1 1 Lines 229 246 +17 Branches 22 23 +1 ========================================== + Hits 205 211 +6 - Misses 24 35 +11 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.