search

nuxt-modules / html-validator

HTML validation for Nuxt
https://html-validator.nuxtjs.org
MIT License
197 stars 22 forks source link

chore: test bundler module resolution #454

Closed danielroe closed 10 months ago

danielroe commented 10 months ago

This is a 'canary' pull request. It aims to ensure that the ecosystem is ready for a shift in the default Nuxt TypeScript module resolution from 'Legacy' to 'Bundler': https://github.com/nuxt/nuxt/pull/24837. You'll need to run your build + type checking tests to verify that things still work; I'm hoping that CI will do that for us so we get an immediate indication of whether there's anything to investigate further here.

'Bundler' module resolution is recommended by Vue and by Vite, but unfortunately there are still many packages that do not have the correct entries in their package.json.

This might include this module or packages that are used by this module. You can see, for example: https://arethetypeswrong.github.io/?p=@nuxtjs/html-validator. The initial red X for node10 needs to be fixed in https://github.com/nuxt/module-builder; you can ignore that for now.

If there are any errors reported in CI for this PR, it would be good to fix them for the sake of any users of this module who enable the Bundler module resolution. Feel free to ping me or others on the Nuxt Discord if you need any help resolving any issues discovered by this PR - and feel free to check out https://github.com/nuxt/nuxt/pull/24837 for any feedback or comments from others affected.

netlify[bot] commented 10 months ago

Deploy Preview for html-validator canceled.

Name Link
Latest commit ae0f3ffbc16fc16db0ebce6bf02d19c9afe0146e
Latest deploy log https://app.netlify.com/sites/html-validator/deploys/65843acdad32ea0008c53f5e
codecov[bot] commented 10 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (b76b7ed) 86.93% compared to head (ae0f3ff) 78.99%. Report is 4 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #454 +/- ## ========================================== - Coverage 86.93% 78.99% -7.94% ========================================== Files 3 4 +1 Lines 199 219 +20 Branches 45 46 +1 ========================================== Hits 173 173 - Misses 26 46 +20 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.