nuxt-modules / i18n

I18n module for Nuxt
https://i18n.nuxtjs.org
MIT License
1.75k stars 483 forks source link

fix: pure comment triggering rollup warnings #2725

Closed BobbieGoede closed 9 months ago

BobbieGoede commented 10 months ago

🔗 Linked issue

❓ Type of change

📚 Description

Resolves #2640

Alternative to #2723, uses #__NO_SIDE_EFFECTS__ instead as described in the document referenced in https://github.com/nuxt-modules/i18n/pull/2723/files#r1462054212 as well as https://rollupjs.org/configuration-options/#no-side-effects.

📝 Checklist

BobbieGoede commented 10 months ago

I still have to test if this would still work with webpack

kazupon commented 9 months ago

I still have to test if this would still work with webpack

webpack is not support. 😅

FYI: https://github.com/javascript-compiler-hints/compiler-notations-spec/blob/main/no-side-effects-notation-compatibility.md

BobbieGoede commented 9 months ago

I still have to test if this would still work with webpack

webpack is not support. 😅

FYI: javascript-compiler-hints/compiler-notations-spec@main/no-side-effects-notation-compatibility.md

Ah I understand, that's unfortunate! I'll close this PR.