fix: `setLocale` throws error updating locale cookie from plugin - Githubissues

nuxt-modules / i18n

I18n module for Nuxt

https://i18n.nuxtjs.org

MIT License

1.71k stars 478 forks source link

fix: `setLocale` throws error updating locale cookie from plugin #2783

Closed BobbieGoede closed 7 months ago

BobbieGoede commented 7 months ago

🔗 Linked issue

2554
2777

❓ Type of change

[ ] 📖 Documentation (updates to the documentation or readme)
[x] 🐞 Bug fix (a non-breaking change that fixes an issue)
[ ] 👌 Enhancement (improving an existing functionality like performance)
[ ] ✨ New feature (a non-breaking change that adds functionality)
[ ] ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This should be a more complete fix for https://github.com/nuxt-modules/i18n/issues/2554#issuecomment-1939318875, looks like the main issue was the useCookie usage, which this PR moves out of the function and passes the CookieRef to the utility/internal functions instead.

📝 Checklist

[x] I have linked an issue or discussion.
[ ] I have updated the documentation accordingly.