fix: sync cookie when setting locale

[BobbieGoede]

🔗 Linked issue

• 2829

❓ Type of change

• [ ] 📖 Documentation (updates to the documentation, readme or JSdoc annotations)
• [x] 🐞 Bug fix (a non-breaking change that fixes an issue)
• [ ] 👌 Enhancement (improving an existing functionality like performance)
• [ ] ✨ New feature (a non-breaking change that adds functionality)
• [ ] 🧹 Chore (updates to the build process or auxiliary tools and libraries)
• [ ] ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Resolves #2829

Please note that this actually changes the cookie behavior slightly, this is why I set this RP to draft status.

These changes ensure that the cookie is always set and up to date (if configured of course), even when no redirection takes place necessarily. I feel like this would only ensure the correct locale is used even if the user has not been redirected (e.g. entering the website on a page in which redirection would occur anyways), are there any downsides to this change?

If we want to keep this change we may need to adjust the documentation a bit, I haven't looked into this yet.

📝 Checklist

• [x] I have linked an issue or discussion.
• [x] I have added tests (if possible).
• [x] I have updated the documentation accordingly.

[kazupon]

These changes ensure that the cookie is always set and up to date (if configured of course), even when no redirection takes place necessarily. I feel like this would only ensure the correct locale is used even if the user has not been redirected (e.g. entering the website on a page in which redirection would occur anyways), are there any downsides to this change?

Thanks for your fixing! I believe that your fix is no downside. In fact, your change has passed testing and has not caused any regression. Let’s merge this PR!

[makamekm]

It looks like this PR has broken the package with infinity redirects in some browsers like Opera or Yandex.

[BobbieGoede]

It looks like this PR has broken the package with infinity redirects in some browsers like Opera or Yandex.

Can you open an issue with a minimal reproduction? 🙏