fix: locale head reactivity on locale change for `strategy: 'no_prefix'`

BobbieGoede commented 6 months ago

🔗 Linked issue

2871

❓ Type of change

[ ] 📖 Documentation (updates to the documentation, readme or JSdoc annotations)
[x] 🐞 Bug fix (a non-breaking change that fixes an issue)
[ ] 👌 Enhancement (improving an existing functionality like performance)
[ ] ✨ New feature (a non-breaking change that adds functionality)
[ ] 🧹 Chore (updates to the build process or auxiliary tools and libraries)
[ ] ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Resolves #2871

Even though SEO tags don't make much sense for the unprefixed routing strategy, the locale head composable also handles the lang and dir attributes which do need to be updated.

📝 Checklist

[x] I have linked an issue or discussion.
[x] I have added tests (if possible).
[ ] I have updated the documentation accordingly.

kazupon commented 6 months ago

This PR has still regression, that implementation still looks not enough to me. https://github.com/nuxt-modules/i18n/actions/runs/8538876258/job/23392425785

BobbieGoede commented 5 months ago

This PR has still regression, that implementation still looks not enough to me. nuxt-modules/i18n/actions/runs/8538876258/job/23392425785

Normally we wait for URL change to deal with flakiness but that's not possible for no_prefix so this made the test flaky, I added a workaround for this.

meirroth commented 5 months ago

@kazupon When will this fix be released?

BobbieGoede commented 5 months ago

@meirroth I just published v8.3.1 that includes this change

nuxt-modules / i18n