nuxt-modules / i18n

I18n module for Nuxt
https://i18n.nuxtjs.org
MIT License
1.75k stars 483 forks source link

Generated canonical links do not point to main language, but to current language #2925

Closed vibonacci closed 4 months ago

vibonacci commented 7 months ago

Environment

"@nuxtjs/i18n": "^8.3.0" "nuxt": "^3.11.2"

Reproduction

N/A

Describe the bug

Given the config below, the generated canonical link for the page in the default lang en on http://localhost:3000 will be correct: <link rel="canonical" href="http://localhost:3000/" data-hid="5cca6f5">

However, switching to the nl locale, the generated canonical link will point to the URL with /nl appended: <link rel="canonical" href="http://localhost:3000/nl" data-hid="5cca6f5">

The canonical link should point to the main language link as these pages are considered the same for SEO purposes, only have different language.

Using the prefix_except_default strategy.

  i18n: {
    vueI18n: './i18n.config.ts',
    baseUrl: process.env.FRONTEND_URL,
    langDir: 'translations',
    lazy: true,
    locales: [
      // https://i18n.nuxtjs.org/docs/guide/seo#feature-details
      {
        code: 'en',
        iso: 'en-US',
        file: 'en.js',
        isCatchallLocale: true,
      },
      {
        code: 'nl',
        iso: 'nl-NL',
        file: 'nl.js',
      },
    ],
    defaultLocale: 'en',
    // https://i18n.nuxtjs.org/docs/guide#strategies
    strategy: 'prefix_except_default',
}

Additional context

No response

Logs

No response

github-actions[bot] commented 6 months ago

Would you be able to provide a reproduction? πŸ™

More info ### Why do I need to provide a reproduction? Reproductions make it possible for us to triage and fix issues quickly with a relatively small team. It helps us discover the source of the problem, and also can reveal assumptions you or we might be making. ### What will happen? If you've provided a reproduction, we'll remove the label and try to reproduce the issue. If we can, we'll mark it as a bug and prioritise it based on its severity and how many people we think it might affect. If `needs reproduction` labeled issues don't receive any substantial activity (e.g., new comments featuring a reproduction link), we'll close them. That's not because we don't care! At any point, feel free to comment with a reproduction and we'll reopen it. ### How can I create a reproduction? We have a couple of templates for starting with a minimal reproduction: πŸ‘‰ [Reproduction starter (v8 and higher)](https://stackblitz.com/fork/github/BobbieGoede/nuxt-i18n-starter/tree/v8) πŸ‘‰ [Reproduction starter (edge)](https://stackblitz.com/fork/github/BobbieGoede/nuxt-i18n-starter/tree/edge) A public GitHub repository is also perfect. πŸ‘Œ Please ensure that the reproduction is as **minimal** as possible. See more details [in our guide](https://nuxt.com/docs/community/reporting-bugs/#create-a-minimal-reproduction). You might also find these other articles interesting and/or helpful: - [The Importance of Reproductions](https://antfu.me/posts/why-reproductions-are-required) - [How to Generate a Minimal, Complete, and Verifiable Example](https://stackoverflow.com/help/mcve)
carlosvaldesweb commented 5 months ago

X2 Also happen to me

kazupon commented 4 months ago

Closing due to inactivity. Please open a new issue with a reference to this one if you can follow up with more information.

Thanks!

WooHoo-Wu commented 4 months ago

X2 ζˆ‘δΉŸι‡εˆ°θΏ‡θΏ™η§ζƒ…ε†΅

WaldemarEnns commented 2 months ago

I guess I have a reproduction for this at https://github.com/nuxt-modules/i18n/issues/3099