nuxt-modules / i18n

I18n module for Nuxt
https://i18n.nuxtjs.org
MIT License
1.75k stars 483 forks source link

refactor: restructure extend vue-i18n #3017

Closed BobbieGoede closed 4 months ago

BobbieGoede commented 4 months ago

πŸ”— Linked issue

❓ Type of change

πŸ“š Description

We still have some split logic between this module and what was originally in vue-i18n-routing, because of this we were extending vue-i18n in two places.

After some reorganizing I noticed that onExtendExportGlobal and onExtendVueI18n were actually doing the same thing but with different variable names πŸ€” possibly __composerExtend did the same as well, after merging and generalizing these extends it appears to still be working.

I feel like my changes should have broken something.. πŸ˜‚ Either the refactored code was interchangeable or it contains untested logic πŸ€”

πŸ“ Checklist