[ ] π Documentation (updates to the documentation, readme or JSdoc annotations)
[ ] π Bug fix (a non-breaking change that fixes an issue)
[ ] π Enhancement (improving an existing functionality like performance)
[ ] β¨ New feature (a non-breaking change that adds functionality)
[x] π§Ή Chore (updates to the build process or auxiliary tools and libraries)
[ ] β οΈ Breaking change (fix or feature that would cause existing functionality to change)
π Description
We still have some split logic between this module and what was originally in vue-i18n-routing, because of this we were extending vue-i18n in two places.
After some reorganizing I noticed that onExtendExportGlobal and onExtendVueI18n were actually doing the same thing but with different variable names π€ possibly __composerExtend did the same as well, after merging and generalizing these extends it appears to still be working.
I feel like my changes should have broken something.. π Either the refactored code was interchangeable or it contains untested logic π€
π Linked issue
β Type of change
π Description
We still have some split logic between this module and what was originally in
vue-i18n-routing
, because of this we were extendingvue-i18n
in two places.After some reorganizing I noticed that
onExtendExportGlobal
andonExtendVueI18n
were actually doing the same thing but with different variable names π€ possibly__composerExtend
did the same as well, after merging and generalizing these extends it appears to still be working.I feel like my changes should have broken something.. π Either the refactored code was interchangeable or it contains untested logic π€
π Checklist