search

nuxt-modules / og-image

Generate OG Images with Vue templates in Nuxt.
https://nuxtseo.com/og-image
361 stars 23 forks source link

fix: don't skip normalising routes with `.` in final segment #161

Closed danielroe closed 3 months ago

danielroe commented 4 months ago

With new URL pattern for og images, I wonder if we can now omit this part of isInternalRoute?

In some cases users will have routes with a full-stop but this will still have OG images, for example https://github.com/danielroe/page-speed.dev.

related https://github.com/danielroe/page-speed.dev/commit/53e968666bb10ebbaf648e72e15768fcc3ffaf12.

harlan-zw commented 4 months ago

Oh man, file checking in URLs kills me. There was a non obvious reason for this, will try remember. Otherwise looks good