search

nuxt-modules / og-image

Generate OG Images with Vue templates in Nuxt.
https://nuxtseo.com/og-image
360 stars 23 forks source link

'terminate' package uses GPL-2.0 license where 'og-image' uses MIT #212

Closed sethidden closed 1 week ago

sethidden commented 1 month ago

It's used in the package runtime (not as a development tool) here https://github.com/nuxt-modules/og-image/blob/16e1ed6b81db9539e76680df2ddcecf119b34ef2/src/runtime/nitro/og-image/bindings/chromium/on-demand.ts#L30

A change introduced in this commit: https://github.com/nuxt-modules/og-image/commit/e0cdde74906c5862757c070b379b393e2a9e8bd7

License SPDX in terminate: https://github.com/dwyl/terminate/blob/main/package.json#L32 Also see:

As per GPL-2.0 section 2

  1. You may modify your copy or copies of the Program or any portion of it, thus forming a work based on the Program, and copy and distribute such modifications or work under the terms of Section 1 above, provided that you also meet all of these conditions: ... b) You must cause any work that you distribute or publish, that in whole or in part contains or is derived from the Program or any part thereof, to be licensed as a whole at no charge to all third parties under the terms of this License.

Shouldn't this package be GPL-ed or stop using terminate to keep using MIT?

manniL commented 4 weeks ago

cc @harlan-zw

sethidden commented 3 weeks ago

@harlan-zw I read your post in terminate. Could you let me know the particular doubts you're having in regards to the GPL/MIT license?

harlan-zw commented 3 weeks ago

I was looking for the maintainer to comment ideally.

For context, we need this package as occasionally browser gets stuck open in the CI.

I don't have capacity right now to replace this package with bespoke code or find an alternative fix so changing the license upstream would be ideal. PRs are also welcome of course :)