nuxt-modules / og-image

Generate OG Images with Vue templates in Nuxt.
https://nuxtseo.com/og-image
400 stars 25 forks source link

Generate single image for same url with different query param values #83

Closed bogdanciuca closed 12 months ago

bogdanciuca commented 1 year ago

Clear and concise description of the problem

When using routes with query params for things like content filtering, the lib / crawler treats them as individual urls and generates an image for each param value, which is expected.

However, having many possible param values leads to very slow build times and large builds that grow exponentially.

Suggested solution

Add a new config property, i.e. ignoreUrlQueryParams, that tells the lib to treat all links with query params as the same url and generate a single OG image for all of them.

harlan-zw commented 1 year ago

Hi @bogdanciuca, can you confirm which version you're using? Afaik it should only generate a single entry in the latest

bogdanciuca commented 1 year ago

Hi @harlan-zw , thanks for the quick response. I'm using the latest version of SEO KIT ("nuxt-seo-kit": "^1.3.13"). Let me know if your need other info, or if I should create the issue in the nuxt-seo-kit repo instead.

dargmuesli commented 1 year ago

The latest nuxt-og-image version is v2, which is included in @nuxtseo/module (which is nuxt-seo-kit v2, beta).

harlan-zw commented 1 year ago

Hi @harlan-zw , thanks for the quick response. I'm using the latest version of SEO KIT ("nuxt-seo-kit": "^1.3.13"). Let me know if your need other info, or if I should create the issue in the nuxt-seo-kit repo instead.

I'll update the docs to make this clearer but what Jonas said above. Basically there's breaking changes (and a bunch of bug fixes) between the major versions and Nuxt SEO Kit v1 can't update to it

bogdanciuca commented 1 year ago

The latest nuxt-og-image version is v2, which is included in @nuxtseo/module (which is nuxt-seo-kit v2, beta).

I saw that nuxt-og-image got to v2, but I missed the new @nuxtseo/module. Thanks, will try it out and get back.

I'll update the docs to make this clearer but what Jonas said above. Basically there's breaking changes (and a bunch of bug fixes) between the major versions and Nuxt SEO Kit v1 can't update to it

That would be useful, thanks!

bogdanciuca commented 1 year ago

I've migrated to @nuxtseo/module (2.0.0-beta.31) but I'm getting the same behaviour. Some logs:

  ├─ /personal-medical?specializare=Dermatologie/__og_image__/og.png (1264ms) 19%                                                                                         nitro 8:20:08 PM
  ├─ /personal-medical?specializare=Pneumologie/__og_image__/og.png (1212ms) 20%                                                                                          nitro 8:20:09 PM
  ├─ /personal-medical?specializare=Endocrinologie/__og_image__/og.png (663259ms) 21%                                                                                     nitro 8:31:13 PM
  ├─ /personal-medical?specializare=Reumatologie/__og_image__/og.png (1337ms) 22%                                                                                         nitro 8:31:14 PM
  ├─ /personal-medical?specializare=Neurochirurgie/__og_image__/og.png (1291ms) 24%                                                                                       nitro 8:31:15 PM
  ├─ /personal-medical?specializare=Medicina Dentara/__og_image__/og.png (1193ms) 25%                                                                                     nitro 8:31:16 PM
  ├─ /personal-medical?specializare=Medicina Generala/__og_image__/og.png (1204ms) 26%                                                                                    nitro 8:31:18 PM
  ├─ /personal-medical?specializare=Chirurgie Generala/__og_image__/og.png (1214ms) 27%                                                                                   nitro 8:31:19 PM
  ├─ /personal-medical?specializare=Chirurgie Reconstructiva/__og_image__/og.png (1188ms) 28%                                                                             nitro 8:31:20 PM
  ├─ /personal-medical?specializare=Chirurgie Plastica/__og_image__/og.png (1253ms) 29%                                                                                   nitro 8:31:21 PM
  ├─ /personal-medical?specializare=Medicina Interna/__og_image__/og.png (1204ms) 31%                                                                                     nitro 8:31:23 PM
  ├─ /personal-medical?specializare=Fizioterapie/__og_image__/og.png (1191ms) 32%                                                                                         nitro 8:31:24 PM
  ├─ /personal-medical?specializare=Urologie/__og_image__/og.png (1169ms) 33%                                                                                             nitro 8:31:25 PM
  ├─ /personal-medical?specializare=Kinetoterapie/__og_image__/og.png (29673ms) 34%                                                                                       nitro 8:31:55 PM
  ├─ /personal-medical?specializare=Masaj/__og_image__/og.png (1370ms) 35%                                                                                                nitro 8:31:56 PM
  ├─ /personal-medical?specializare=Laborator Analize/__og_image__/og.png (1317ms) 36%                                                                                    nitro 8:31:57 PM
  ├─ /personal-medical?specializare=Ginecologie/__og_image__/og.png (1177ms) 38%                                                                                          nitro 8:31:58 PM
  ├─ /personal-medical?specializare=Ecografie/__og_image__/og.png (1239ms) 39%                                                                                            nitro 8:32:00 PM
  ├─ /personal-medical?specializare=Chirurgie Vasculara/__og_image__/og.png (1192ms) 40%                                                                                  nitro 8:32:01 PM
  ├─ /personal-medical?specializare=Ortopedie/__og_image__/og.png (1234ms) 41%                                                                                            nitro 8:32:02 PM
  ├─ /personal-medical?specializare=Cardiologie/__og_image__/og.png (1148ms) 42%                                                                                          nitro 8:32:03 PM
  ├─ /personal-medical?specializare=Medicina Muncii/__og_image__/og.png (1167ms) 44%                                                                                      nitro 8:32:04 PM
  ├─ /personal-medical?specializare=Alergologie/__og_image__/og.png (1199ms) 45%                                                                                          nitro 8:32:06 PM
  ├─ /personal-medical?specializare=Ecografie Doppler/__og_image__/og.png (1209ms) 46%                                                                                    nitro 8:32:07 PM
  ├─ /personal-medical?specializare=ORL/__og_image__/og.png (1169ms) 47%                                                                                                  nitro 8:32:08 PM
  ├─ /personal-medical?specializare=Oncologie/__og_image__/og.png (1171ms) 48%                                                                                            nitro 8:32:09 PM
  ├─ /articole?subiect=specializări noi/__og_image__/og.png (1119ms) 49%                                                                                                  nitro 8:32:10 PM
  ├─ /articole?subiect=ortopedie/__og_image__/og.png (1110ms) 51%                                                                                                         nitro 8:32:11 PM
  ├─ /articole?subiect=neurochirurgie/__og_image__/og.png (1128ms) 52%                                                                                                    nitro 8:32:13 PM
  ├─ /articole?subiect=recuperare medicală/__og_image__/og.png (1148ms) 53%                                                                                               nitro 8:32:14 PM
  ├─ /articole?subiect=medici noi/__og_image__/og.png (1111ms) 54%                                                                                                        nitro 8:32:15 PM
  ├─ /articole?subiect=colestrol/__og_image__/og.png (1401ms) 55%                                                                                                         nitro 8:32:16 PM
  ├─ /articole?subiect=program medical comunitar/__og_image__/og.png (1149ms) 56%                                                                                         nitro 8:32:17 PM
  ├─ /articole?subiect=gratuite/__og_image__/og.png (1112ms) 58%                                                                                                          nitro 8:32:18 PM
  ├─ /articole?subiect=medici stomatologi/__og_image__/og.png (1190ms) 59%                                                                                                nitro 8:32:20 PM
  ├─ /articole?subiect=consultații și tratamente/__og_image__/og.png (1168ms) 60%                                                                                         nitro 8:32:21 PM
  ├─ /articole?subiect=Centrul Medical Diaconia/__og_image__/og.png (1166ms) 61%                                                                                          nitro 8:32:22 PM
  ├─ /articole?subiect=servicii medicale/__og_image__/og.png (1219ms) 62%                                                                                                 nitro 8:32:23 PM
  ├─ /articole?subiect=Ianca/__og_image__/og.png (1128ms) 64%                                                                                                             nitro 8:32:24 PM
  ├─ /articole?subiect=teste de glicemie/__og_image__/og.png (1133ms) 65%                                                                                                 nitro 8:32:25 PM
  ├─ /laborator-analize?litera=1/__og_image__/og.png (1189ms) 66%                                                                                                         nitro 8:32:27 PM
  ├─ /articole/specializari-si-medici-noi/__og_image__/og.png (1158ms) 67%                                                                                                nitro 8:32:28 PM
  ├─ /articole/servicii-medicale-gratuite-19-23-iunie/__og_image__/og.png (1125ms) 68%                                                                                    nitro 8:32:29 PM
  ├─ /articole/program-medical-comunitar-in-ianca-17-iunie/__og_image__/og.png (1129ms) 69%                                                                               nitro 8:32:30 PM
  ├─ /laborator-analize?litera=2/__og_image__/og.png (1187ms) 71%                                                                                                         nitro 8:32:31 PM
  ├─ /laborator-analize?litera=B/__og_image__/og.png (1185ms) 72%                                                                                                         nitro 8:32:32 PM
  ├─ /laborator-analize?litera=A/__og_image__/og.png (1199ms) 73%                                                                                                         nitro 8:32:34 PM
  ├─ /laborator-analize?litera=C/__og_image__/og.png (1164ms) 74%                                                                                                         nitro 8:32:35 PM
  ├─ /laborator-analize?litera=D/__og_image__/og.png (1186ms) 75%                                                                                                         nitro 8:32:36 PM
  ├─ /laborator-analize?litera=E/__og_image__/og.png (1147ms) 76%                                                                                                         nitro 8:32:37 PM
  ├─ /laborator-analize?litera=J/__og_image__/og.png (1167ms) 78%                                                                                                         nitro 8:32:38 PM
  ├─ /laborator-analize?litera=K/__og_image__/og.png (1185ms) 79%                                                                                                         nitro 8:32:39 PM
  ├─ /laborator-analize?litera=H/__og_image__/og.png (1178ms) 80%                                                                                                         nitro 8:32:41 PM
  ├─ /laborator-analize?litera=F/__og_image__/og.png (1157ms) 81%                                                                                                         nitro 8:32:42 PM
  ├─ /laborator-analize?litera=I/__og_image__/og.png (1178ms) 82%                                                                                                         nitro 8:32:43 PM
  ├─ /laborator-analize?litera=G/__og_image__/og.png (1196ms) 84%                                                                                                         nitro 8:32:44 PM
  ├─ /laborator-analize?litera=N/__og_image__/og.png (1188ms) 85%                                                                                                         nitro 8:32:45 PM
  ├─ /laborator-analize?litera=P/__og_image__/og.png (1179ms) 86%                                                                                                         nitro 8:32:47 PM
  ├─ /laborator-analize?litera=O/__og_image__/og.png (1209ms) 87%                                                                                                         nitro 8:32:48 PM
  ├─ /laborator-analize?litera=L/__og_image__/og.png (1159ms) 88%                                                                                                         nitro 8:32:49 PM
  ├─ /laborator-analize?litera=M/__og_image__/og.png (1181ms) 89%                                                                                                         nitro 8:32:50 PM
  ├─ /laborator-analize?litera=T/__og_image__/og.png (1186ms) 91%                                                                                                         nitro 8:32:51 PM
  ├─ /laborator-analize?litera=S/__og_image__/og.png (1183ms) 92%                                                                                                         nitro 8:32:52 PM
  ├─ /laborator-analize?litera=U/__og_image__/og.png (1195ms) 93%                                                                                                         nitro 8:32:54 PM
  ├─ /laborator-analize?litera=X/__og_image__/og.png (1152ms) 94%                                                                                                         nitro 8:32:55 PM
  ├─ /laborator-analize?litera=R/__og_image__/og.png (1332ms) 95%                                                                                                         nitro 8:32:56 PM
  ├─ /laborator-analize?litera=Y/__og_image__/og.png (1163ms) 96%                                                                                                         nitro 8:32:57 PM
  ├─ /laborator-analize?litera=V/__og_image__/og.png (1169ms) 98%                                                                                                         nitro 8:32:58 PM
  ├─ /laborator-analize?litera=Q/__og_image__/og.png (1197ms) 99%                                                                                                         nitro 8:33:00 PM
  └─ /laborator-analize?litera=Z/__og_image__/og.png (1183ms) 100%                                                                                                        nitro 8:33:01 PM

I'm also having a new issue now, the crawler fails to see some static file urls. Logs:

 ├─ /informatii-pacienti [2 errors]                                                                                                                                      nitro 8:33:03 PM
    /documente/politica-gdpr.doc                                                                                                                                          nitro 8:33:03 PM
        ✖ Should not respond with status code 404 (Not Found). (no-error-response)                                                                                       nitro 8:33:03 PM
    /documente/politica-gdpr.doc                                                                                                                                          nitro 8:33:03 PM
        ✖ Should not respond with status code 404 (Not Found). (no-error-response)                                                                                       nitro 8:33:03 PM
bogdanciuca commented 1 year ago

@harlan-zw Any other suggestions?

harlan-zw commented 12 months ago

Thanks for the stacktrace. I was testing this for the Satori images, not the screenshots.

Should be fixed in the next release.

bogdanciuca commented 11 months ago

@harlan-zw thanks, that worked! I've opened a follow up issue for static files link checking.