Closed danielroe closed 8 months ago
Name | Link |
---|---|
Latest commit | 503ca8dac9bcd4088c6b789aab1544061e0ada45 |
Latest deploy log | https://app.netlify.com/sites/prismic-module/deploys/6601985363de4800086e6168 |
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 100.00%. Comparing base (
4ce471f
) to head (503ca8d
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Thanks! Will ship this week along other fixes and maintenance stuff 🚀
Types of changes
Description
This is a very early PR to make this module compatible with changes we expect to release in Nuxt v5.
In Nuxt v3.7.0 we added support for
import.meta.*
(see original PR) and we've been gradually updating docs and moving across from the oldprocess.*
patterned variables.As I'm sure you're aware, these variables are replaced at build-time and enable tree-shaking in bundled code. This change affects runtime code (that is, that is processed by the Nuxt bundler, like vite or webpack) rather than code running in Node. So it really doesn't matter what the string is, but it makes more sense in an ESM-world to use
import.meta
rather thanprocess
.(It might be worth updating the module compatibility as well to indicate it needs to have Nuxt v3.7.0+, but I'll leave that with you if you think this is a good approach.)
Checklist: