nuxt-modules / robots

Tame the robots crawling and indexing your Nuxt site.
https://nuxtseo.com/robots
MIT License
424 stars 34 forks source link

Merge with Nuxt Simple Robots #116

Closed harlan-zw closed 4 months ago

harlan-zw commented 10 months ago

Migration Notes

@nuxtjs/robots v3 breaking changes


This issue is to discuss the possibility of merging with the nuxt-simple-robots module. This is not meant to imply intent, I'll only go ahead with merging if the current maintainers and team give approval for me to do so.

Why Merge

I built the nuxt-simple-robots package as I felt the feature set for this module didn't meet my needs, specifically around modules integrating with it (i.e sitemap module).

The nuxt-simple-robots module offers many important features for end users and module integrations. Some of the ones I think that most useful:

For a comparison in usage:

Having multiple modules in the ecosystem that are tackling the same issue is good in my opinion, it gives the end user choice and encourages innovation. However, given that this robots module is "official" and it's one of the most downloaded for Nuxt, I feel we should be providing a single choice that provides delightful DX out of the box.

What Does Merging Look Like

Who WIll Maintain v4 Onwards?

I'd like to take over the the primary maintainer as I have most context on how the code is working, but would be amazing to have help in continuing to maintain the module.

harlan-zw commented 10 months ago

Hey @ricardogobbosouza you seem to be the sole maintainer at the moment, would you review this when you have a chance, would be great to have your input!

cc: @Atinux

ExEr7um commented 10 months ago

Hey @harlan-zw. I tried to migrate to nuxt-simple-robots today but with no success.

As I can tell, nuxt-simple-robots does support only Allow and Disallow rules of robots.txt. @nuxtjs/robots on the other hand does support much more rules (e.g. CleanParam, CrawlDelay, Host). And as I need to use CleanParam, I can't migrate

I think it is a great idea to get single official module, but it should not be merged as is, first it needs to support all features of @nuxtjs/robots.

harlan-zw commented 10 months ago

All google directives are supported.

I'm open to adding others if you want to make an issue for what's missing, but I wouldn't encourage end users to use them

harlan-zw commented 10 months ago

I want to actively avoid adding rules in robots.txt that don't do anything, this is part of the validation feature.

atinux commented 9 months ago

I am happy with this change in order to bring consistency to the Nuxt community 👍

harlan-zw commented 4 months ago

I'll be going ahead with this and plan to release an v4 rc of @nuxtjs/robots that is nuxt-simple-robots ~tomorrow, with a migration guide.

harlan-zw commented 4 months ago

The migration is now complete as of v4