nuxt-modules / sanity

Sanity integration for Nuxt
https://sanity.nuxtjs.org
MIT License
223 stars 33 forks source link

production build not possible with visualEditing enabled because of missing react/jsx-runtime dep #1050

Open podlebar opened 2 months ago

podlebar commented 2 months ago

Version

module: "@nuxtjs/sanity": "^1.12.1" nuxt: ^3.13.0,

Nuxt configuration

  sanity: {
    projectId: process.env.SANITY_PROJECT_ID,
    dataset: "production",
    useCdn: true,
    apiVersion: "2024-06-25",
    visualEditing: {
      token: process.env.SANITY_READ_TOKEN,
      studioUrl: "http://localhost:3333",
    },
  },

Reproduction

Link: will follow soon

What is expected?

yarn build builds without errors.

What is actually happening?

the build fails with following message:

[12:48:23 PM] ERROR Nuxt Build Error: [vite]: Rollup failed to resolve import "react/jsx-runtime" from "/Users/bart/Documents/viu-web/node_modules/@sanity/visual-editing/dist/_chunks-es/renderVisualEditing.js". This is most likely unintended because it can break your application at runtime. If you do want to externalize this module explicitly add it to build.rollupOptions.external

Steps to reproduce

Run: yarn build

Additional information

i assume it happens from this: https://github.com/nuxt-modules/sanity/commit/13737c55fec963e6d586fc3d1c3c463952bb499c

Checklist

What is expected?

nuxt build gets build without error above.

What is actually happening?

Bildschirmfoto 2024-08-30 um 13 03 09
LucaArgentieri commented 1 month ago

With these versions, there are no errors.

"nuxt": "^3.13.2",
"@nuxtjs/sanity": "^1.12.2",

I hope it helps you.