nuxt-modules / sitemap

Powerfully flexible XML Sitemaps that integrate seamlessly, for Nuxt.
https://nuxtseo.com/sitemap
MIT License
336 stars 31 forks source link

fix(module): prevent false positive warning about ignored root keys #338

Closed madebyfabian closed 3 months ago

madebyfabian commented 3 months ago

๐Ÿ”— Linked issue

Resolved #332

โ“ Type of change

๐Ÿ“š Description

At module startup, when using the multiple sitemaps feature, currently you will recieve a false positive warning about using root config keys that will be ignored. Even though if you haven't defined them. This was because the check was an Object.keys(config).includes() which always returns true since the module config object is filled with default data.

Fixing this by changing the check to test if the values differ from the default ones.

vercel[bot] commented 3 months ago

@madebyfabian is attempting to deploy a commit to the Nuxt Team on Vercel.

A member of the Team first needs to authorize it.

harlan-zw commented 3 months ago

Thanks!