Closed harlan-zw closed 2 months ago
The latest updates on your projects. Learn more about Vercel for Git โ๏ธ
Name | Status | Preview | Updated (UTC) |
---|---|---|---|
sitemap-edge-demo | โ Ready (Inspect) | Visit Preview | Sep 20, 2024 7:29am |
@harlan-zw is a similar change required here?
Thanks for the review @genu, I'm only considering sitemap integration with this module at the moment.
I see, but wouldn't it cause issue when using the main seo module?
For instance, it will polyfill the i18n composable when it should not, since its provided by nuxt-i18n-micro
.
Nuxt throws errors about duplicate composables when using together.
Hmm good point but it's a warning that is thrown so not a big deal, the pollyfills should be registered with low priority though.
Having to support nuxt-i18n-micro in all SEO modules is not something I have capacity for at the moment so if this is a blocker then we may consider closing this PR.
Hmm, I can test a little bit more on my end, as I noticed the polyfill is indeed used instead of the i18n-micro composable.
Maybe the order in the modules array affects this? ๐ค
๐ Linked issue
https://github.com/s00d/nuxt-i18n-micro/issues/11
โ Type of change
๐ Description
As the i18n config has an identical signature we can support the https://github.com/s00d/nuxt-i18n-micro module out of the box without any extra effort :crossed_fingers: