search

nuxt-modules / storybook

Storybook integration with Nuxt.
https://storybook.nuxtjs.org
378 stars 82 forks source link

chore: indicate compatibility with new v4 major #645

Closed danielroe closed 2 weeks ago

danielroe commented 2 weeks ago

With Nuxt 4 on the horizon, this updates the module compatibility definition to allow it to be installed on Nuxt v4. (Otherwise Nuxt will indicate the module might not be compatible.)

When Nuxt v4 comes out then you might decide or need to make breaking changes in this module and release a new major, but hopefully the migration should be smoother. 🙏

👉 You can follow this and other changes in https://github.com/nuxt/nuxt/issues/27613 - please feel free to provide feedback as well!

netlify[bot] commented 2 weeks ago

Deploy Preview for nuxt-storybook ready!

Name Link
Latest commit d5fed11e5a761efd6237feb0e74961672dfce448
Latest deploy log https://app.netlify.com/sites/nuxt-storybook/deploys/666c440f36fadd0008bcaada
Deploy Preview https://deploy-preview-645--nuxt-storybook.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

tobiasdiez commented 2 weeks ago

Thanks @danielroe!

Since the storybook module integrates quite closely to nuxt internals (eg. we copy and modify nuxt's vite config), it is very likely that we are not compatible with v4 without further changes. Would you still recommend to add the compatibility tag?

Otherwise Nuxt will indicate the module might not be compatible.

I feel this might be more honest to the devs that are using the storybook module but are trying out nuxt v4.

danielroe commented 2 weeks ago

I would suggest testing with the new compatibility version: https://nuxt.com/docs/getting-started/upgrade#testing-nuxt-4.

Although we haven’t released v4 yet, this gives a good initial indication.

(For me, there were no red flags for this module in our change log, but obviously testing is safest.)

tobiasdiez commented 2 weeks ago

I've tested the v4 future flag over at https://github.com/nuxt-modules/storybook/pull/648 and it seems that there are indeed no problems. Awesome to see that migration to v4 will be much smoother than v2>v3, also thanks to your proactive PRs in modues.

So let's get this in.