nuxt-modules / storybook

Storybook integration with Nuxt.
https://storybook.nuxtjs.org
411 stars 95 forks source link

feat: Exposing the https options for Storybook dev server #772

Closed brandondv closed 2 months ago

brandondv commented 2 months ago

📚 Description

With this module it's easy to set-up a storybook env. but it isn't possible to use a ssl certificate like the CLI does: storybook dev -p 6006 --https --ssl-cert ./secrets/cert.pem --ssl-key ./secrets/key.pem.

To make that possible with this module I've added/exposed the https options. I used the same format as Nuxt devServer.https options.

You could even argue that we could just reuse the https options from the devServer section directly if they're defined. But to keep it flexible I've kept them separate.

How to test

netlify[bot] commented 2 months ago

Deploy Preview for nuxt-storybook ready!

Name Link
Latest commit fa6c1f98643857da78f9dd4a9ced154a9057cdd0
Latest deploy log https://app.netlify.com/sites/nuxt-storybook/deploys/66db5bb4dc412d00082953fb
Deploy Preview https://deploy-preview-772--nuxt-storybook.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

tobiasdiez commented 2 months ago

Awesome, thanks for your contribution! Codewise it looks good to me. Could you please add a short entry in the documentation in the part about module options? Thanks!

brandondv commented 2 months ago

@tobiasdiez done

tobiasdiez commented 2 months ago

Awesome, thanks a lot!