fix: remove Storybook version from `storybook.ts`

obulat commented 2 months ago

🔗 Linked issue

📚 Description

The Storybook versions in the package.json were updated, but the same change needs to be added to the storybook.ts to prevent version conflicts.

Currently, with nightly, we get the following error:

WARN The following packages are incompatible with Storybook 8.2.7 as they depend on different major versions of Storybook packages:
WARN - @nuxtjs/storybook@8.3.0-28764731.a9bf66d
WARN  Repo: https://storybook.nuxtjs.org
WARN - @storybook-vue/nuxt@8.3.0-28764731.a9bf66d
WARN  Repo: https://storybook.nuxtjs.org
WARN - storybook@8.2.9
WARN  Repo: https://github.com/storybookjs/storybook/tree/next/code/lib/cli
WARN - @storybook/vue3@8.2.9
WARN  Repo: https://github.com/storybookjs/storybook/tree/next/code/renderers/vue3
WARN - @storybook/addon-links@8.2.9
WARN  Repo: https://github.com/storybookjs/storybook/tree/next/code/addons/links
WARN - @storybook/builder-vite@8.2.9
WARN  Repo: https://github.com/storybookjs/storybook/tree/next/code/builders/builder-vite/#readme
WARN - @storybook/addon-essentials@8.2.9
WARN  Repo: https://github.com/storybookjs/storybook/tree/next/code/addons/essentials
WARN - @storybook/addon-interactions@8.2.9
WARN  Repo: https://github.com/storybookjs/storybook/tree/next/code/addons/interactions
WARN - @storybook/test@8.2.9
WARN  Repo: https://github.com/storybookjs/storybook/tree/next/code/lib/test
WARN - @storybook/blocks@8.2.9
WARN  Repo: https://github.com/storybookjs/storybook/tree/next/code/lib/blocks
WARN 
WARN 
WARN Please consider updating your packages or contacting the maintainers for compatibility details.
WARN For more on Storybook 8 compatibility, see the linked GitHub issue:
WARN https://github.com/storybookjs/storybook/issues/26031

 ERROR  Storybook failed to load the following preset: @storybook-vue/nuxt/preset.                                                                                                              nuxt:storybook:build 5:37:16 PM

Please check whether your setup is correct, the Storybook dependencies (and their peer dependencies) are installed correctly and there are no package version clashes.

netlify[bot] commented 2 months ago

Deploy Preview for nuxt-storybook ready!

Name	Link
Latest commit	670403cd6c73a63a1fa7dc68b87c357345be23f9
Latest deploy log	https://app.netlify.com/sites/nuxt-storybook/deploys/66ed247dae41840008bb7319
Deploy Preview	https://deploy-preview-778--nuxt-storybook.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

tobiasdiez commented 2 months ago

Thanks! Now that https://github.com/storybookjs/storybook/pull/28594 is merged, we should actually be able to simply remove the packageJson. Could you please give this a try? (I can also do this on Friday)

obulat commented 2 months ago

Thanks! Now that storybookjs/storybook#28594 is merged, we should actually be able to simply remove the packageJson. Could you please give this a try? (I can also do this on Friday)

I removed the packageJson completely. The CI is passing. Is there anything else that needs to be done?

tobiasdiez commented 2 months ago

Awesome! Thanks for your continued contributions ❤️

nuxt-modules / storybook