search

nuxt-modules / supabase

Supabase module for Nuxt.
https://supabase.nuxtjs.org
MIT License
733 stars 129 forks source link

fix(typo): correct provider_token assignment to cookie #230

Closed blqke closed 1 year ago

blqke commented 1 year ago

Fix assignment of provider_token in Supabase nuxt module

Types of changes

Description

The cookie provider_token was erroneously assigned the value of session.access_token. This fixes it

netlify[bot] commented 1 year ago

Deploy request for n3-supabase pending review.

Visit the deploys page to approve it

Name Link
Latest commit fb4a6714cf28256ee1cd8b7a7d9e3ab853f5ca29
Aietes commented 1 year ago

Actually these two cookies could be removed entirely, they are not used or required?

larbish commented 1 year ago

@Aietes It's needed to access them server side. Here was the original PR: https://github.com/nuxt-modules/supabase/pull/197

Aietes commented 1 year ago

The module is not using those, as these are the tokens from the respective social login. When someone needs to do something with those, they would have their own logic and mechanisms to share and use, so I'm not sure why these cookies should be created by default.