fix: #883 Tab view src leading baseURL

nuxt-modules / tailwindcss

Tailwind CSS module for Nuxt

https://tailwindcss.nuxtjs.org

MIT License

1.69k stars 183 forks source link

fix: #883 Tab view src leading baseURL #885

Closed richardevcom closed 3 months ago

richardevcom commented 3 months ago

Fixed issue #883: Cannot find any path matching /_tailwind/, when using baseUrl: /dev/. Additionally added conditional baseURL output, where if it matches / it prefixes empty string '', making final Tab view src always /dev/_tailwind/ (depending on nuxt.config.ts) or /_tailwind/.

🔗 Linked issue

Issue #883

❓ Type of change

[ x] 🐞 Bug fix (a non-breaking change that fixes an issue)

📚 Description

 Fixed issue #883: Cannot find any path matching /_tailwind/, when using baseUrl: '/dev/'.

This change is required to fix Tailwind Config Viewer embedded url by appending missing baseUrl setting (if set).

netlify[bot] commented 3 months ago

Deploy Preview for nuxt-tailwindcss ready!

Name	Link
Latest commit	6feef565880a0fcf3970f030f3aa12a5a550bfc7
Latest deploy log	https://app.netlify.com/sites/nuxt-tailwindcss/deploys/66abbf962ebedb0008b95b63
Deploy Preview	https://deploy-preview-885--nuxt-tailwindcss.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

what-the-diff[bot] commented 3 months ago

PR Summary

Improvement on URL Handling The 'module.ts' file was worked on to enhance the way we handle URLs in our application. By importing the 'withoutTrailingSlash' function from the 'ufo' library, we can ensure that all URLs used in our application do not have any unwanted trailing slashes. This increases the accuracy and functionality of URLs within our application resulting in a better user experience.
Update in View Object Source Property The source ('src') property in the 'view' object has been refreshed to incorporate the 'withoutTrailingSlash' function. This means that our base URLs, as they are defined in our application's settings, will now be free from trailing slashes, making them more precise and reliable when being utilized. This leads to a more robust system and smoother navigation for our users.

nhh commented 3 months ago

I am using nuxt2 and experiencing a smiliar issue. My app tries to handle /_tailwind and loads nuxt instead of the tw viewer. Is this fix only for nuxt3?