nuxt-modules / turnstile

🔥 Cloudflare Turnstile integration for Nuxt
https://cloudflare.com/products/turnstile
MIT License
216 stars 17 forks source link

docs(readme): make relative links absolute #249

Closed dargmuesli closed 11 months ago

dargmuesli commented 1 year ago

Resolves #248

danielroe commented 1 year ago

This is great. But this is happening to countless modules. Really we need to fix it on nuxt.com by normalising the link addresses.

codecov-commenter commented 1 year ago

Codecov Report

Merging #249 (8c5946f) into main (92bc17f) will not change coverage. The diff coverage is n/a.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##             main     #249   +/-   ##
=======================================
  Coverage   83.47%   83.47%           
=======================================
  Files           2        2           
  Lines         115      115           
  Branches       13       13           
=======================================
  Hits           96       96           
  Misses         19       19           

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

dargmuesli commented 1 year ago

fix it on nuxt.com by normalising the link addresses

Yeah, thought about that proper solution as well! I just made this as a suggestion, already guessed you have the same thoughts :wink:

dargmuesli commented 11 months ago

@danielroe so would you agree that this PR can be closed in favor of a downstream fix?