nuxt-modules / turnstile

🔥 Cloudflare Turnstile integration for Nuxt
https://cloudflare.com/products/turnstile
MIT License
215 stars 17 forks source link

feat(module): warn for missing secret key #296

Open dargmuesli opened 5 months ago

dargmuesli commented 5 months ago

Currently, there is no warning when building a project for production and no secret key is set.

This is the first step I did while working on moving secret sourcing to the runtime: #297 I think it might not the best idea to include a secret in a build, thus my proposal to only source it at runtime.

codecov[bot] commented 5 months ago

Codecov Report

Attention: Patch coverage is 90.90909% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 18.01%. Comparing base (dc164cc) to head (c95024b). Report is 29 commits behind head on main.

Files Patch % Lines
src/runtime/types.ts 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #296 +/- ## ========================================== - Coverage 19.26% 18.01% -1.26% ========================================== Files 12 13 +1 Lines 493 555 +62 Branches 23 25 +2 ========================================== + Hits 95 100 +5 - Misses 398 455 +57 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.