search

nuxt-themes / alpine

The minimalist blog theme, powered by Nuxt & Markdown.
https://alpine.nuxt.space
MIT License
285 stars 54 forks source link

feat(.starters): import alpine-starter into `.starters/default` #135

Closed Tahul closed 1 year ago

Tahul commented 1 year ago

Resolves https://github.com/nuxtlabs/studio-app/issues/821 for Alpine

You can boot the default starter using npm run play:starter.

codesandbox[bot] commented 1 year ago

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
alpine ❌ Failed (Inspect) May 11, 2023 9:06am
Tahul commented 1 year ago

@Atinux ; I think for Alpine the .docs and .starters/default directory are the same.

The only issue that remains is that if we drop .docs in favor of .starters/default, we won't be able to properly run the theme with the local version of Alpine without the need to overwrite some code everytime we want to boot with such setup.

What should I do for this?

I think I can drop .docs and add guidelines for contributing in the readme, or maybe you know a solution?

Tahul commented 1 year ago

Maybe I could also work a bit on backend side that makes the copy of our starters and support overwriting the package.json at that time. 🤷

Tahul commented 1 year ago

(The scripts rewrite obviously breaks the deployment, I guess doing deployments from Studio itself is the point of these PRs anyways)

larbish commented 1 year ago

What is the issue with the deployment ? What is the difference with https://github.com/Atinux/content-wind (it used the .demo folder in production already) ?

Atinux commented 1 year ago

@Atinux ; I think for Alpine the .docs and .starters/default directory are the same.

The only issue that remains is that if we drop .docs in favor of .starters/default, we won't be able to properly run the theme with the local version of Alpine without the need to overwrite some code everytime we want to boot with such setup.

What should I do for this?

I think I can drop .docs and add guidelines for contributing in the readme, or maybe you know a solution?

Actually it works well with content-wind thanks to pnpm workspace linking automatically in development so we should not have to change anything normally

Atinux commented 1 year ago

So .starters/default is the new .docs

nuxt-studio[bot] commented 1 year ago

Live Preview ready!

Name Edit Preview Latest Commit
Alpine Edit on Studio ↗︎ View Live Preview cdd12b66921fa6ea3853650e4987ed7b8f372dc5