Closed bdrtsky closed 1 year ago
What you think @Tahul @Atinux
One solution would be to inherit typography.color.primary
from color.primary
so the user can customise the typography color if needed.
What do you think @bdrtsky ?
Great suggestion, I've pushed it https://github.com/nuxt-themes/typography/pull/19/commits/863c5da5bec38f8e12ae066e49e7f4178294dfff
Current tokens structure have few limitations. For example links (and all other elements using
typography.color
) are not automatically inheritingcolor
from app. There's few questions I like to discusstypography.color
tocolor
, so app colors applying without any user action. But there's a chance that user might want to have separate colors for his typography. For example, we has blue as hiscolor.primary
but he wants lightblue palette to be applied on typography.typography.fontSize
,typography.letterSpacing
,typography.fontWeight
,typography.lead
? Currently they also scoped totypography
. Which means that if user installs Typography, possibly could have 2 separate typography tokens, because he could havefontSize
,letterSpacing
,fontWeight
,lead
already. Does it make sense to enforce Typography tokens if user decide to install package?lead
tolineHeight
I've started PR here, but then those questions appeared - https://github.com/nuxt-themes/typography/pull/19