search

nuxt-themes / typography

Beautifully customizable Prose components for Nuxt Content.
https://typography.nuxt.space
MIT License
163 stars 7 forks source link

feat: default background color #33

Closed alexchopin closed 1 year ago

alexchopin commented 1 year ago

Add background-color for dark and light mode, otherwise we have a white text on a white background on dark mode by default.

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
typography ✅ Ready (Inspect) Visit Preview Feb 14, 2023 at 6:36PM (UTC)
Tahul commented 1 year ago

@bdrtsky wdyt?

I'm unsure this is the right place to put this styling though.

Atinux commented 1 year ago

I agree the UX could be improved, it's frustrating to have the white texte on white background.

But I am not sure about the implementation, how can they update their background color if we hard code colors.white and colors.black then?

I am fine documenting instead that they need to set html.dark to use their custom background color for example.