nuxt-themes / typography

Beautifully customizable Prose components for Nuxt Content.
https://typography.nuxt.space
MIT License
164 stars 7 forks source link

Code: copy button should be at bottom #5

Closed atinux closed 1 year ago

atinux commented 1 year ago

CleanShot 2022-11-07 at 19.44.02@2x.png

See on https://nuxt-com-git-feat-typography-nuxtlabs.vercel.app/docs/getting-started/configuration

atinux commented 1 year ago

Happy to fix this today @bdrtsky ?

bdrtsky commented 1 year ago

How do you have it? it's empty here https://github.com/nuxt-themes/typography/blob/main/components/CopyButton.vue

bdrtsky commented 1 year ago

Why CopyButton even exist in this repo @Tahul

Tahul commented 1 year ago

I think there is two issues here:

What I would suggest is:

I would suggest it is called ProseCodeCopyButton now, as it might conflict with other components from the user project, CopyButton seem a bit too generic as a name.

atinux commented 1 year ago

I like ProseCodeCopyButton

Happy to remove it from nuxt.com once we have it.

I believe a ProseCode that has a copy button is great UX by default :)