search

nuxt-themes / typography

Beautifully customizable Prose components for Nuxt Content.
https://typography.nuxt.space
MIT License
164 stars 7 forks source link

fix: h1 top margin #6

Closed bdrtsky closed 1 year ago

bdrtsky commented 1 year ago

Resolves #4

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
typography ✅ Ready (Inspect) Visit Preview Nov 7, 2022 at 6:53PM (UTC)
atinux commented 1 year ago

I think the margin-top 0 for h1 can be good enough for us to move forward, but not the final solution since it should also work if I start with a h2 heading.

See my comment on https://volta.net/nuxt-themes/typography/issues/4#comment-1351117

bdrtsky commented 1 year ago

Your comment isn't related to h2 tag in any way.

atinux commented 1 year ago

My comment and issue if about headings, not only h1 :)

bdrtsky commented 1 year ago

What I meant, is that selector you showed as examples makes 0 sense in our case.

atinux commented 1 year ago

I pasted as example if it can help, basically for us it is about to remove the margin if the heading is the first element within its container.