search

nuxt-themes / typography

Beautifully customizable Prose components for Nuxt Content.
https://typography.nuxt.space
MIT License
164 stars 7 forks source link

Global styles #9

Closed atinux closed 1 year ago

atinux commented 1 year ago

It would be nice to support light and dark by default, as well as adding anti aliasing too.

WDYT @bdrtsky @Tahul ?

bdrtsky commented 1 year ago

If you mean global styles, then I believe background color shouldn't be in this repo. Having color mode tokens split between two codebases feels wrong. You suggest to put body text color here, and body background color elsewhere?

As for Prose, then we already have dark/light variations there, isn't it? Most of it actually just inherited from body styles, or whatever you have on parent.

atinux commented 1 year ago

I am thinking about the text color and background color for code for example that could be set.

Checkout the dark mode on https://content-wind-git-feat-prose-atinux.vercel.app/

PR: https://github.com/Atinux/content-wind/pull/34

bdrtsky commented 1 year ago

Code will be handled by Shiki theme

atinux commented 1 year ago

Then what about antialiasing and default text color?

Tahul commented 1 year ago

I think it is obvious we need to ship a global stylesheet (.css) with that prose.

What are the styles we are limiting ourselves to there?

I would try to keep it as "minimal" as possible.