build: do not emit `.mjs` in runtime directory

danielroe commented 8 months ago

🔗 Linked issue

resolves https://github.com/nuxt/content/issues/2512

❓ Type of change

[ ] 📖 Documentation (updates to the documentation or readme)
[x] 🐞 Bug fix (a non-breaking change that fixes an issue)
[ ] 👌 Enhancement (improving an existing functionality like performance)
[ ] ✨ New feature (a non-breaking change that adds functionality)
[ ] ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

We probably need to fix this in nuxt/module-builder, but adding the new entrypoint didn't overwrite existing one, so both .js and .mjs files were being created.

📝 Checklist

[ ] I have linked an issue or discussion.
[ ] I have updated the documentation accordingly.

cloudflare-workers-and-pages[bot] commented 8 months ago

Deploying with Cloudflare Pages

Latest commit:	`f87d44c`
Status:	✅ Deploy successful!
Preview URL:	https://1c800e20.nuxt-content-1il.pages.dev
Branch Preview URL:	https://build-mjs.nuxt-content-1il.pages.dev

View logs

farnabaz commented 8 months ago

Thanks @danielroe What about module file? Why not removing mjs and cjs and just create .js extension?

danielroe commented 8 months ago

I'd be very happy with that as well, but it shouldn't be linked to the bug and I wanted to keep the surface area of the change limited.

nuxt / content