fix(prerender): ensure `/` exists inside prerender rotues

nuxt / content

The file-based CMS for your Nuxt application, powered by Markdown and Vue components.

https://content.nuxt.com

MIT License

3.13k stars 627 forks source link

Closed farnabaz closed 4 months ago

farnabaz commented 4 months ago

[ ] 📖 Documentation (updates to the documentation or readme)
[x] 🐞 Bug fix (a non-breaking change that fixes an issue)
[ ] 👌 Enhancement (improving an existing functionality like performance)
[ ] ✨ New feature (a non-breaking change that adds functionality)
[ ] ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

cloudflare-workers-and-pages[bot] commented 4 months ago

Latest commit:	`48d10a3`
Status:	✅ Deploy successful!
Preview URL:	https://b9c3b835.nuxt-content-1il.pages.dev
Branch Preview URL:	https://prerender-home.nuxt-content-1il.pages.dev

stefanprobst commented 4 months ago

@farnabaz i think this breaks nuxt/i18n, which intentionally removes "/" from prerendering so redirecting to "/en" still works. see https://github.com/nuxt-modules/i18n/pull/2894

ptdev commented 4 months ago

@farnabaz i think this breaks nuxt/i18n, which intentionally removes "/" from prerendering

Confirming that it did indeed break i18n. See #2678

ydnar commented 4 months ago

This PR, with its unilateral addition of / to the prerender list, broke production for us.