search

nuxt / create-nuxt-app

Create Nuxt.js App in seconds.
MIT License
3.48k stars 429 forks source link

feat(cna,template): add src directory prompt #853

Closed NozomuIkuta closed 1 year ago

NozomuIkuta commented 3 years ago

Resolve #243 (maybe)

I don't know who mainly manages this repository. So let me request a review from @Atinux and please change reviewers as needed. 🙏

@ushironoko

Is this what you meant in the original issue? If so, I appreciate your review on this PR too. If not, I appreciate additional explanation in the original issue so that I could help.

Explanation of work

Most are explained in the code.

Just in case, I checked files in cna-template/template/frameworks directory, and I believe there is no relative paths (e.g. ../) used to refer to other files. This means changing srcDir doesn't break any such statements. If I should add unit tests for combination of srcDir and frameworks, I will so let me know.

👷‍♂️ Since this is my very first PR for create-nuxt-app tool, I may be making mistakes or missing something. 👷‍♀️

atinux commented 3 years ago

Actually I still need to discuss with the team but I am not found of adding such question at the beginning, this is quite an advanced usage and should not be directly in the scaffolding tool.

NozomuIkuta commented 1 year ago

Let me close this PR since it's stale.