search

nuxt / devtools

Unleash Nuxt Developer Experience
https://devtools.nuxt.com
MIT License
2.85k stars 153 forks source link

fix: open graph breaks when tag value is numeric #563

Closed Aareksio closed 8 months ago

Aareksio commented 8 months ago

🐛 The bug

useSeoMeta({
  ogImageWidth: 200,
});

When item.value is numeric, item.value.match is not a function at https://github.com/nuxt/devtools/blob/b483fdee05017aeb3d81857dfaefb741838706dc/packages/devtools/client/pages/modules/open-graph.vue#L160

Results in broken "Tags" section:

Screenshot 2024-01-07 at 22 56 52

🛠️ To reproduce

https://stackblitz.com/edit/github-gqikj7

🌈 Expected behavior

Tab not breaking :)

Screenshot 2024-01-07 at 22 58 22

ℹ️ Additional context

No response

arashsheyda commented 8 months ago

@Aareksio I can't see the problem exactly, it's working

Screenshot 2024-01-09 at 12 31 52 PM
Aareksio commented 8 months ago

@arashsheyda You are right, it only happens after installing @nuxtseo/module (now moved to @nuxtjs/seo). Updated repro. I am not sure which repo this issue belongs, technically it is something about unhead, but in the end it is easy fix in nuxt-devtools.

arashsheyda commented 8 months ago

@Aareksio I'll try to install it and test it then, thanks (and if you like to fix it PR welcome)