Include `eslint-plugin-regexp` in `tooling` preset

nuxt / eslint

Collection of ESLint-related packages for Nuxt

https://eslint.nuxt.com

MIT License

539 stars 65 forks source link

Include `eslint-plugin-regexp` in `tooling` preset #432

Closed antfu closed 4 months ago

antfu commented 4 months ago

Describe the feature

https://github.com/ota-meshi/eslint-plugin-regexp is a great tool to analyze and provide feedback to potential regex mistakes or slow regexes. I believe it's great tools for module author to catch those warnings during development.

Additional information

[X] Would you be willing to help implement this feature?
[ ] Could this feature be implemented as a module?

Final checks

[X] Read the contribution guide.
[X] Check existing discussions and issues.

antfu commented 4 months ago

/cc @danielroe What do you think? If we do, should we do a minor bump? (in that case I think we might figure out a versioning policy for this repo and mention it in the docs)

For my own config, I don't consider adding rules as breaking: https://github.com/antfu/eslint-config#versioning-policy

But since this could be a bit destructive, I want to double-check and ensure they way we do this aligns with Nuxt's philosophy.

Example of these rules in nuxt/nuxt: https://github.com/nuxt/nuxt/pull/27207

danielroe commented 4 months ago

This seems good to me - (nice plugin!) - and I think a minor bump should be fine. Do you think we could provide a single flag to disable, e.g.regepx: false?