nuxt / eslint

Collection of ESLint-related packages for Nuxt
https://eslint.nuxt.com
MIT License
515 stars 65 forks source link

feat(config): add `no-import-type-side-effects` rule of `@typescript-eslint` #439

Open shinGangan opened 1 month ago

shinGangan commented 1 month ago

Describe the feature

Currently, @typescript-eslint/consistent-type-imports is set as the typescript-eslint rule.

Since fixStyle is not specified, I think fixStyle: separate-type-imports will be applied.


I would like to suggest enabling @typescript-eslint/no-import-type-side-effects along with fixStyle: separate-type-imports being applied. By adding this rule, it is possible to suppress variations in separate-type-imports and inline-type-imports on the user side.

However, I think whether to add a rule that disallows inline types to the official ESLint rules is an issue that requires discussion.

Additional information

Final checks

shinGangan commented 1 month ago

Hi @antfu , I would appreciate it if you could comment when you have time. 🙏